Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EI-133: Improve setup #7

Merged
merged 3 commits into from
Sep 26, 2024
Merged

EI-133: Improve setup #7

merged 3 commits into from
Sep 26, 2024

Conversation

ksu00
Copy link

@ksu00 ksu00 commented Sep 19, 2024 •
edited
Loading

This patch improves the setup by:

  • Splitting up dev dependencies into dev and test dependencies. Currently, the test dependencies consists of only pytest, but more are to come in the future. 😃
  • Making dependency groups optional.
  • Updating the setup instructions in the README.

Additional changes:

  • Use same version range for python as other already set up repos of the nightskycam project.
  • Update pytest version range in order to enable version solving by poetry when setting up this repo as a submodule of nightskycam.
  • Update .gitignore.
  • Add __init__.py to tests directory.

Closes EI-133

@ksu00 ksu00 requested a review from vincentberenz September 19, 2024 13:10
@ksu00 ksu00 self-assigned this Sep 19, 2024
ksu00
ksu00 commented Sep 19, 2024
View reviewed changes
pyproject.toml Show resolved Hide resolved
ksu00
ksu00 commented Sep 19, 2024
View reviewed changes
pyproject.toml Show resolved Hide resolved
vincentberenz
vincentberenz approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@vincentberenz vincentberenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good

@vincentberenz
Copy link
Contributor

@ksu00 Hello, your updates broke the continuous integration on github. You will need to fix before being able to merge. Continuous integration setup is in .github/workflows

@jcpassy jcpassy force-pushed the issues/EI-133-setup branch from d12e341 to 3770a6e Compare September 26, 2024 14:13
@jcpassy jcpassy merged commit 29d9f66 into develop Sep 26, 2024
5 checks passed
@jcpassy jcpassy deleted the issues/EI-133-setup branch September 26, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentberenz vincentberenz vincentberenz approved these changes

Assignees

@ksu00 ksu00

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ksu00 @vincentberenz @jcpassy